fixed errors found by tests; fixed tests

test/bones73k_web/live/property_live_test.exs

@@ -54,14 +54,23 @@ defmodule Bones73kWeb.PropertyLiveTest do
              |> form("#property-form", property: @invalid_attrs)
              |> render_change() =~ "can't be blank"
 
-      {:ok, _, html} =
-        index_live
-        |> form("#property-form", property: @create_attrs)
-        |> render_submit()
-        |> follow_redirect(conn, Routes.property_index_path(conn, :index))
+      # update form attrs
+      index_live
+      |> form("#property-form", property: @update_attrs)
+      |> render_change()
 
+      # submit new form attrs
+      index_live
+      |> form("#property-form", property: @update_attrs)
+      |> render_submit()
+
+      # send modal close event & observe results
+      send(index_live.pid, {:close_modal, true})
+      html = render(index_live)
+
+      assert_patched(index_live, Routes.property_index_path(conn, :index))
       assert html =~ "Property created successfully"
-      assert html =~ "some description"
+      assert html =~ "some updated description"
     end
 
     test "updates property in listing", %{conn: conn, property: property} do
@@ -76,12 +85,21 @@ defmodule Bones73kWeb.PropertyLiveTest do
              |> form("#property-form", property: @invalid_attrs)
              |> render_change() =~ "can't be blank"
 
-      {:ok, _, html} =
-        index_live
-        |> form("#property-form", property: @update_attrs)
-        |> render_submit()
-        |> follow_redirect(conn, Routes.property_index_path(conn, :index))
+      # update form attrs
+      index_live
+      |> form("#property-form", property: @update_attrs)
+      |> render_change()
 
+      # submit new form attrs
+      index_live
+      |> form("#property-form", property: @update_attrs)
+      |> render_submit()
+
+      # send modal close event & observe results
+      send(index_live.pid, {:close_modal, true})
+      html = render(index_live)
+
+      assert_patched(index_live, Routes.property_index_path(conn, :index))
       assert html =~ "Property updated successfully"
       assert html =~ "some updated description"
     end
@@ -130,12 +148,21 @@ defmodule Bones73kWeb.PropertyLiveTest do
              |> form("#property-form", property: @invalid_attrs)
              |> render_change() =~ "can't be blank"
 
-      {:ok, _, html} =
-        index_live
-        |> form("#property-form", property: @update_attrs)
-        |> render_submit()
-        |> follow_redirect(conn, Routes.property_index_path(conn, :index))
+      # update form attrs
+      index_live
+      |> form("#property-form", property: @update_attrs)
+      |> render_change()
 
+      # submit new form attrs
+      index_live
+      |> form("#property-form", property: @update_attrs)
+      |> render_submit()
+
+      # send modal close event & observe results
+      send(index_live.pid, {:close_modal, true})
+      html = render(index_live)
+
+      assert_patched(index_live, Routes.property_index_path(conn, :index))
       assert html =~ "Property updated successfully"
       assert html =~ "some updated description"
     end
@@ -257,12 +284,21 @@ defmodule Bones73kWeb.PropertyLiveTest do
              |> form("#property-form", property: @invalid_attrs)
              |> render_change() =~ "can't be blank"
 
-      {:ok, _, html} =
-        show_live
-        |> form("#property-form", property: @update_attrs)
-        |> render_submit()
-        |> follow_redirect(conn, Routes.property_show_path(conn, :show, property))
+      # update form attrs
+      show_live
+      |> form("#property-form", property: @update_attrs)
+      |> render_change()
 
+      # submit new form attrs
+      show_live
+      |> form("#property-form", property: @update_attrs)
+      |> render_submit()
+
+      # send modal close event & observe results
+      send(show_live.pid, {:close_modal, true})
+      html = render(show_live)
+
+      assert_patched(show_live, Routes.property_show_path(conn, :show, property))
       assert html =~ "Property updated successfully"
       assert html =~ "some updated description"
     end
@@ -293,12 +329,21 @@ defmodule Bones73kWeb.PropertyLiveTest do
              |> form("#property-form", property: @invalid_attrs)
              |> render_change() =~ "can't be blank"
 
-      {:ok, _, html} =
-        show_live
-        |> form("#property-form", property: @update_attrs)
-        |> render_submit()
-        |> follow_redirect(conn, Routes.property_show_path(conn, :show, property))
+      # update form attrs
+      show_live
+      |> form("#property-form", property: @update_attrs)
+      |> render_change()
 
+      # submit new form attrs
+      show_live
+      |> form("#property-form", property: @update_attrs)
+      |> render_submit()
+
+      # send modal close event & observe results
+      send(show_live.pid, {:close_modal, true})
+      html = render(show_live)
+
+      assert_patched(show_live, Routes.property_show_path(conn, :show, property))
       assert html =~ "Property updated successfully"
       assert html =~ "some updated description"
     end

test/support/fixtures/accounts_fixtures.ex

@@ -36,7 +36,7 @@ defmodule Bones73k.AccountsFixtures do
     # {:ok, captured} = fun.(&"[TOKEN]#{&1}[TOKEN]")
     # [_, token, _] = String.split(captured.body, "[TOKEN]")
     # token
-    %Bamboo.Email{} = email = fun.(&"[TOKEN]#{&1}[TOKEN]")
+    {:ok, %Bamboo.Email{} = email} = fun.(&"[TOKEN]#{&1}[TOKEN]")
     [_, token, _] = String.split(email.text_body, "[TOKEN]")
     token
   end